Skip to content

Add api doc for ngif#27376

Closed
jbogarthyde wants to merge 2 commits intoangular:masterfrom
jbogarthyde:jb-apidoc-ngif
Closed

Add api doc for ngif#27376
jbogarthyde wants to merge 2 commits intoangular:masterfrom
jbogarthyde:jb-apidoc-ngif

Conversation

@jbogarthyde
Copy link
Copy Markdown
Contributor

@jbogarthyde jbogarthyde commented Nov 30, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

https://angular-team.atlassian.net/browse/DOCS-122

@jbogarthyde jbogarthyde added type: bug/fix comp: docs target: patch This PR is targeted for the next patch release labels Nov 30, 2018
@ngbot ngbot bot modified the milestone: needsTriage Nov 30, 2018
@jbogarthyde jbogarthyde added the state: needs eng review Needs technical review and approval from engineering team label Nov 30, 2018
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Nov 30, 2018

You can preview 21b3d2d at https://pr27376-21b3d2d.ngbuilds.io/.

@jbogarthyde jbogarthyde mentioned this pull request Nov 30, 2018
Closed
3 tasks
trotyl
trotyl reviewed Dec 1, 2018
View reviewed changes
Comment thread packages/common/src/directives/ng_if.ts Outdated
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Dec 3, 2018

You can preview 8c7936c at https://pr27376-8c7936c.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Dec 4, 2018

You can preview 89c859e at https://pr27376-89c859e.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Dec 5, 2018

You can preview 4ec6e89 at https://pr27376-4ec6e89.ngbuilds.io/.

@brandonroberts brandonroberts modified the milestones: needsTriage, Backlog Dec 6, 2018
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Dec 6, 2018

You can preview 5d08af2 at https://pr27376-5d08af2.ngbuilds.io/.

petebacondarwin
petebacondarwin reviewed Dec 6, 2018
View reviewed changes
Comment thread packages/common/src/directives/ng_if.ts Outdated
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Jan 16, 2019

You can preview 57330e0 at https://pr27376-57330e0.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Jan 17, 2019

You can preview e8c65cd at https://pr27376-e8c65cd.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Jan 18, 2019

You can preview c950547 at https://pr27376-c950547.ngbuilds.io/.

brandonroberts
brandonroberts suggested changes Jan 21, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add descriptions for inputs

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Jan 21, 2019

You can preview 5644959 at https://pr27376-5644959.ngbuilds.io/.

@brandonroberts brandonroberts removed the request for review from IgorMinar January 21, 2019 19:56
@brandonroberts brandonroberts added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jan 21, 2019
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Jan 21, 2019
@brandonroberts
Copy link
Copy Markdown
Contributor

brandonroberts commented Jan 21, 2019

Caretaker note: This is a docs-only change that should not impact g3. Please run presubmit.

@brandonroberts brandonroberts added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Jan 22, 2019
@alxhub
Copy link
Copy Markdown
Member

alxhub commented Jan 22, 2019

Presubmit

@alxhub alxhub closed this in 661a98a Jan 22, 2019
alxhub pushed a commit that referenced this pull request Jan 22, 2019
@jbogarthyde @alxhub
docs: add input docs (#27376)
589dd47 
PR Close #27376
brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Jan 24, 2019
@jbogarthyde @brandonroberts
docs: add api doc for ngif (angular#27376)
5e39416 
PR Close angular#27376
@brandonroberts brandonroberts mentioned this pull request Jan 24, 2019
Closed
14 tasks
jasonaden pushed a commit that referenced this pull request Jan 24, 2019
@jbogarthyde @jasonaden
docs: add api doc for ngif (#27376) (#28344)
35f7ff0 
PR Close #27376

PR Close #28344
@jbogarthyde jbogarthyde deleted the jb-apidoc-ngif branch January 25, 2019 17:39
vetom pushed a commit to vetom/angular that referenced this pull request Jan 31, 2019
@jbogarthyde @vetom
docs: add api doc for ngif (angular#27376)
ceb7aaa 
PR Close angular#27376
vetom pushed a commit to vetom/angular that referenced this pull request Jan 31, 2019
@jbogarthyde @vetom
docs: add input docs (angular#27376)
54106fb 
PR Close angular#27376
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 14, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@trotyl trotyl trotyl left review comments

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@brandonroberts brandonroberts brandonroberts approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@petebacondarwin petebacondarwin

Labels

action: merge The PR is ready for merge by the caretaker cla: yes effort2: days merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: low state: needs eng review Needs technical review and approval from engineering team target: major This PR is targeted for the next major release type: bug/fix

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

7 participants

@jbogarthyde @mary-poppins @brandonroberts @alxhub @petebacondarwin @trotyl @googlebot